Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes #19162; enable strictEffects for v2 #19380

Merged
merged 36 commits into from
Oct 15, 2022
Merged

fixes #19162; enable strictEffects for v2 #19380

merged 36 commits into from
Oct 15, 2022

Conversation

ringabout
Copy link
Member

@ringabout ringabout commented Jan 13, 2022 •
edited
Loading

fixes #19162

issues tracking

See also #19303

@Araq
Copy link
Member

Araq commented Jan 16, 2022

Tests need to be updated but important packages seem to work, so please proceed.

@ringabout ringabout mentioned this pull request Jan 17, 2022
Merged
@ringabout
Copy link
Member Author

Here is the progress of fixing important packages:

nitely/nim-regex#110

@ringabout ringabout closed this Jan 20, 2022
@ringabout ringabout reopened this Jan 20, 2022
@ringabout ringabout mentioned this pull request Jan 20, 2022
Merged
@ringabout
Copy link
Member Author

made a PR for arraymancer: mratsim/Arraymancer#549

mratsim pushed a commit to mratsim/Arraymancer that referenced this pull request Jan 21, 2022
@ringabout
add stricteffects support (#549)
c4807e5 
* add stricteffects support

ref nim-lang/Nim#19380

* add more effectsof

* more
@ringabout ringabout mentioned this pull request Jan 24, 2022
Merged
@ringabout ringabout mentioned this pull request May 11, 2022
Closed
33 tasks
@ringabout ringabout added v2 and removed v2 labels Aug 8, 2022
ringabout added a commit that referenced this pull request Sep 23, 2022
@ringabout
close #19380; add testcase
4e7c3a0
@ringabout ringabout mentioned this pull request Sep 23, 2022
Closed
@ringabout ringabout mentioned this pull request Oct 6, 2022
Closed
@ringabout ringabout mentioned this pull request Oct 14, 2022
Merged
@ringabout ringabout mentioned this pull request Oct 14, 2022
Merged
Araq
Araq reviewed Oct 15, 2022
View reviewed changes
compiler/sempass2.nim Outdated Show resolved Hide resolved
@Araq Araq mentioned this pull request Oct 15, 2022
Closed
@ringabout ringabout requested a review from Araq October 15, 2022 11:44
@Araq Araq merged commit 1e15f97 into nim-lang:devel Oct 15, 2022
@github-actions
Copy link
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 1e15f97

Hint: mm: orc; opt: speed; options: -d:release
162749 lines; 8.317s; 614.703MiB peakmem

@ringabout ringabout mentioned this pull request Oct 18, 2022
Merged
This was referenced Oct 31, 2022
Closed
Merged
capocasa pushed a commit to capocasa/Nim that referenced this pull request Mar 31, 2023
@ringabout @capocasa
fixes nim-lang#19162; enable strictEffects for v2 (nim-lang#19380)
8832aea 
* enable stricteffects
* add gcsafe
* fix tests
* use func
* fixes pegs tests
* explicitly mark repr related procs with noSideEffect
* add nimLegacyEffects
* change URL
* fixes docopt
* add `raises: []` to repr
* fixes weave
* fixes nimyaml
* fixes glob
* fixes parsetoml
* Apply suggestions from code review
* Update testament/important_packages.nim
* add legacy:laxEffects
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
Requires Araq To Merge PR should only be merged by Araq Showstopper
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Experimental features in normal manual instead of experimental manual/undocumented
3 participants
@ringabout @Araq @Varriount